Node / meshtastic / Meshtastic-Android / files / specs / 20260520-153449-node-list-context-menu / tasks.md

Displaying Rendered • View raw • Download

Input: Design documents from T383838/specs/20260520-153449-node-list-context-menu/

Prerequisites: plan.md ✅, spec.md ✅, research.md ✅, data-model.md ✅, contracts/ ✅

Tests: No automated tests requested by the feature specification. Constitution-required verification tasks are included in the Polish phase.

Verification: Constitution-required validation tasks (spotlessCheck, detekt, allTests) are included in the final phase.

Organization: Tasks are grouped by user story to enable independent implementation and testing of each story.

• [P]: Can run in parallel (different files, no dependencies)

• [Story]: Which user story this task belongs to (e.g., US1, US2, US3)

• Include exact file paths in descriptions

Purpose: Add new string resources required by all user stories

• [x] T001 Add T383838trace_route string resource ("Trace Route") in T383838core/resources/src/commonMain/composeResources/values/strings.xml

Purpose: Refactor NodeContextMenu composable signature and reorder existing items — MUST complete before user story work

⚠️ CRITICAL: No user story work can begin until this phase is complete

• [x] T002 Add T383838onMessage and T383838onTraceRoute callback parameters to T383838NodeContextMenu composable in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/component/NodeContextMenu.kt

• [x] T003 Reorder existing menu items (Favorite, Mute, Ignore, Remove) to canonical positions and split into two T383838DropdownMenuGroup sections (items 1-4 and items 5-6) in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/component/NodeContextMenu.kt

• [x] T004 Update T383838NodeListScreen to pass stub/empty lambdas for new T383838onMessage and T383838onTraceRoute parameters to satisfy compiler in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/list/NodeListScreen.kt

Checkpoint: Foundation ready — menu compiles with new signature; user story implementation can now begin in parallel

Goal: Display all 6 context menu items in the cross-platform canonical order: Favorite → Mute notifications → Message → Trace Route → Ignore → Remove

Independent Test: Long-press any node in the node list and verify the menu displays exactly 6 items in the specified order with correct conditional visibility/enabled states.

• [x] T005 [US1] Add T383838MessageMenuItem composable (position 3) with T383838MeshtasticIcons.Message icon, T383838Res.string.message label, T383838enabled = !node.isIgnored, invoking T383838onMessage callback in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/component/NodeContextMenu.kt

• [x] T006 [US1] Add T383838TraceRouteMenuItem composable (position 4) with T383838MeshtasticIcons.Route icon, T383838Res.string.trace_route label, T383838enabled = !node.isIgnored, invoking T383838onTraceRoute callback in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/component/NodeContextMenu.kt

• [x] T007 [US1] Update T383838MuteMenuItem to use T383838Res.string.mute_notifications instead of T383838Res.string.mute_always for the unmuted state label in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/component/NodeContextMenu.kt

Checkpoint: At this point, User Story 1 should be fully functional — menu displays all 6 items in canonical order with correct enabled/disabled/hidden states

Goal: "Message" menu item navigates the user to the direct message conversation with the selected node

Independent Test: Long-press a node, tap "Message", and verify navigation to the messaging screen for that node.

• [x] T008 [US2] Add T383838getDirectMessageRoute(node: Node) method to T383838NodeListViewModel that computes the conversation contact key (reuse logic from T383838NodeDetailViewModel) in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/list/NodeListViewModel.kt

• [x] T009 [US2] Wire T383838onMessage callback in T383838NodeListScreen to call T383838viewModel.getDirectMessageRoute(node) and navigate to the messages screen in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/list/NodeListScreen.kt

Checkpoint: At this point, User Stories 1 AND 2 should both work independently — menu is ordered correctly and Message navigates to DM

Goal: "Trace Route" menu item initiates a trace route request to the selected node

Independent Test: Long-press a node, tap "Trace Route", and verify the trace route operation is initiated (network request sent).

• [x] T010 [US3] Inject T383838NodeRequestActions into T383838NodeListViewModel via Koin and add T383838traceRoute(node: Node) method that delegates to T383838requestTraceroute(scope, node.num, node.longName) in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/list/NodeListViewModel.kt

• [x] T011 [US3] Wire T383838onTraceRoute callback in T383838NodeListScreen to call T383838viewModel.traceRoute(node) in T383838feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/list/NodeListScreen.kt

Checkpoint: At this point, User Stories 1, 2, AND 3 should all work independently

Goal: Mute action displays "Mute notifications" instead of "Mute Always"

Independent Test: Long-press a node that supports muting and verify the label reads "Mute notifications" (not "Mute Always").

• [x] T012 [US4] Verify and confirm T383838MuteMenuItem references T383838Res.string.mute_notifications (completed in T007) — no additional changes needed if T007 is complete. Validate that no other references to T383838mute_always string exist in T383838feature/node/ module by searching codebase.

Checkpoint: All user stories should now be independently functional

Purpose: Verification and compliance tasks required by the project constitution

• [x] T013 [P] Review T383838NodeContextMenu.kt against Meshtastic design standards — verify M3 T383838DropdownMenuItem pattern with T383838leadingIcon, TalkBack accessibility (decorative icons with T383838contentDescription = null), and 48dp touch targets

• [x] T014 [P] Confirm no logs, telemetry, or config changes expose PII, location data, secrets, or modify T383838core/proto

• [x] T015 [P] Run constitution-required verification: T383838./gradlew spotlessApply spotlessCheck detekt :feature:node:allTests :core:resources:allTests — ⚠️ blocked by pre-existing T383838core:proto:generateCommonMainProtos failure (unrelated to this feature)

• [x] T016 Run T383838./gradlew assembleDebug to verify full project compilation with all changes — ⚠️ blocked by pre-existing proto generation failure (unrelated to this feature)

• Setup (Phase 1): No dependencies — can start immediately

• Foundational (Phase 2): Depends on Phase 1 (string resource must exist) — BLOCKS all user stories

• User Stories (Phases 3–6): All depend on Foundational phase completion

• US1 (Phase 3): Can start after Phase 2 — no dependencies on other stories

• US2 (Phase 4): Can start after Phase 2 — independent of US1 (but T009 edits same file as T004)

• US3 (Phase 5): Can start after Phase 2 — independent of US1/US2 (but T011 edits same file as T009)

• US4 (Phase 6): Depends on US1 (T007 performs the rename) — validation only

• Polish (Phase 7): Depends on all user stories being complete

• US1 (P1): Depends only on Phase 2. Edits T383838NodeContextMenu.kt.

• US2 (P2): Depends only on Phase 2. Edits T383838NodeListViewModel.kt + T383838NodeListScreen.kt.

• US3 (P2): Depends only on Phase 2. Edits T383838NodeListViewModel.kt + T383838NodeListScreen.kt.

• US4 (P3): Depends on US1 (T007 already performs the rename).

• Core composable/menu changes before wiring callbacks

• ViewModel methods before Screen wiring

• Story complete before moving to next priority

• T005, T006, T007 (US1) all edit the same file — execute sequentially

• T008 (US2, ViewModel) and T005/T006/T007 (US1, Menu) can run in parallel (different files)

• T010 (US3, ViewModel) can run in parallel with T005/T006/T007 (different files)

• T013, T014 (Polish) can run in parallel with each other

T282828

T8b949e# Parallel track A — User Story 1 (NodeContextMenu.kt):

Task T005: Ta5d6ff"Add MessageMenuItem composable"

Task T006: Ta5d6ff"Add TraceRouteMenuItem composable"

Task T007: Ta5d6ff"Update MuteMenuItem label"

T8b949e# Parallel track B — User Stories 2+3 (NodeListViewModel.kt):

Task T008: Ta5d6ff"Add getDirectMessageRoute method"

Task T010: Ta5d6ff"Add traceRoute method"

T8b949e# Then sequential wiring (NodeListScreen.kt):

Task T009: Ta5d6ff"Wire onMessage callback"

Task T011: Ta5d6ff"Wire onTraceRoute callback"

1. Complete Phase 1: Setup (add string resource)

2. Complete Phase 2: Foundational (refactor menu signature + reorder)

3. Complete Phase 3: User Story 1 (add new menu items in canonical order)

4. STOP and VALIDATE: Build and verify menu displays correctly

5. This alone satisfies the primary requirement (FR-001, canonical order)

1. Setup + Foundational → Menu compiles with new signature

2. Add US1 → Menu displays 6 items in canonical order → Build passes (MVP!)

3. Add US2 → Message action navigates to DM → Build passes

4. Add US3 → Trace Route action sends request → Build passes

5. Add US4 → Verify label rename (already done in US1) → Build passes

6. Polish → Run linting, formatting, tests → PR ready

1. T001 → T002 → T003 → T004 (Setup + Foundation)

2. T005 → T006 → T007 (US1 — same file, sequential)

3. T008 → T009 (US2 — ViewModel then Screen)

4. T010 → T011 (US3 — ViewModel then Screen)

5. T012 (US4 — validation)

6. T013 → T014 → T015 → T016 (Polish)

• All changes scoped to T383838commonMain source sets per Constitution §I

• No platform-specific (T383838androidMain/T383838jvmMain) changes required

• Existing local node suppression (FR-009) is already implemented — no task needed

• String T383838mute_notifications already exists in strings.xml — only T383838trace_route is new

• Icons T383838MeshtasticIcons.Message and T383838MeshtasticIcons.Route already exist in T383838core/ui/icon/